fix(golang): use datatype only for enums instead of format#24337
Open
rubenhoenle wants to merge 2 commits into
Open
fix(golang): use datatype only for enums instead of format#24337rubenhoenle wants to merge 2 commits into
rubenhoenle wants to merge 2 commits into
Conversation
Contributor
Author
|
See the linked GitHub issue for context of the latest change to this PR. |
rubenhoenle
marked this pull request as ready for review
July 20, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #24336
Detailed description and steps to reproduce can be found in the linked GitHub issue.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5
Summary by cubic
Fixes Go enum generation when a schema sets format: "enum" by always using the base data type in generated enums. Prevents invalid types in both models and properties.
go/model_enum.mustacheto use{{dataType}}for the enum type, the UnmarshalJSON value, and the NewXFromValue parameter, removing reliance on{{format}}.Written for commit 3a44bf6. Summary will update on new commits.