fix(ci): avoid mutable npm CLI in publish workflow#20
Closed
BunsDev wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces supply-chain risk in the npm publishing pipeline by removing a release-time installation of an unpinned npm@latest, ensuring the workflow uses the npm that ships with the Node.js toolchain provisioned by actions/setup-node@v6.
Changes:
- Removed
npm install -g npm@latestfrom the publish workflow. - Replaced the npm setup step with a simple
npm --versionverification step while preservingnpm publish --provenance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm@latestimmediately beforenpm publish --provenance, creating a supply-chain risk by executing a mutable registry-provided CLI in the trusted publishing path.Description
npm install -g npm@lateststep from.github/workflows/npm-publish.ymland replace it with a simplenpm --versionverification so the workflow uses the npm bundled withactions/setup-node@v6(Node 24) instead.Testing
rg -n "npm install -g npm@latest|npm@latest" .github/workflows || trueand verified there are no remaining occurrences in the workflows and thenpm publish --access public --provenancepublish step is preserved.Codex Task