fix(tools): enforce REPL execution permissions#28
Open
BunsDev wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens the Rust REPL tool’s security model by ensuring code execution is gated by the repository’s permission handler, preventing model-supplied code from running without an explicit Execute permission decision.
Changes:
- Adds an explicit
ctx.check_permission(...)gate before creating/reusing a REPL session. - Validates the requested interpreter language early and errors out for unsupported languages before any permission prompt.
- Adds a regression test asserting permission denial prevents REPL session creation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
REPLtool previously executed model-supplied code (bash/python/node) without consulting the repository's permission handler, allowing a model or prompt-injection to run arbitrary local commands despitePermissionLevel::Executemetadata.AutoPermissionHandlerand interactive flows can deny or prompt before code execution.Description
ctx.check_permission(self.name(), &reason, false)before spawning or reusing a REPL session incrates/tools/src/repl_tool.rs.interpreter_for(&language)and return an error for unsupported languages before prompting.repl_tool.rsthat uses aDenyPermissionHandlerand asserts the tool returns a permission error and does not create a REPL session.crates/tools/src/repl_tool.rsand its unit tests to preserve existing architecture and behavior.Testing
cargo test --package claurst-tools repl_tool::tests::execute_denies_without_repl_session_when_permission_denied -- --nocapture— passed.cargo check --package claurst-tools— passed.rustfmt --edition 2021 --check src-rust/crates/tools/src/repl_tool.rs— passed.cargo check --workspacecould not be completed in this environment due to missing systemalsapkg-config files required byalsa-sys(external system dependency), andcargo clippy --all-targets -D warningsis blocked by pre-existing clippy warnings inclaurst-coreunrelated to this patch.Codex Task