Skip to content

Clear displayed_etag on etag-less full refresh #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balloob wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clear displayed_etag on etag-less full refresh #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/display_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1751,7 +1751,13 @@ void handleDirectWriteEnd(uint8_t* data, uint16_t len) {
esp32_restart_ble_advertising();
#endif
if (refreshSuccess) {
// A successful refresh changed the panel image. Commit the new etag
// when the client supplied a valid one; otherwise clear the stale etag
// (etag-less full upload / auto-complete) so a later partial update
// gets a clean ETAG mismatch and falls back to a full upload instead
// of diffing against the wrong, now-outdated base image.
if (hasNewEtag && newEtag != 0) displayed_etag = newEtag;
else displayed_etag = 0;
uint8_t refreshResponse[] = {0x00, 0x73};
sendResponse(refreshResponse, sizeof(refreshResponse));
} else {
Expand Down