fix: exclude wasm from Rust workspace to fix Python sdist packaging#42
Merged
Conversation
The sdist built by maturin includes rust/Cargo.toml (the workspace root needed to resolve the core path dependency) but not rust/wasm/ (which is not in the Python package's dependency tree). This caused cargo vendor to fail when packaging for OpenSUSE because the workspace declared a member directory that didn't exist in the tarball. The wasm crate is standalone. It declares all its dependencies directly and doesn't rely on any workspace-level config, so removing it from the workspace doesn't affect the wasm-pack build in CI. Fixes OpenDisplay#40
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
g4bri3lDev
added a commit
that referenced
this pull request
Jun 29, 2026
The workspace-root fix in #42 didn't trigger a release-please bump because it lived outside the packages/python path. This path-scoped change bumps the package to 5.0.7 so the corrected sdist publishes to PyPI, and adds a CI guard asserting the sdist's embedded workspace manifest is loadable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sdist built by maturin includes rust/Cargo.toml (the workspace root needed to resolve the core path dependency) but not rust/wasm/ (which is not in the Python package's dependency tree). This caused cargo vendor to fail when packaging for OpenSUSE because the workspace declared a member directory that didn't exist in the tarball.
The wasm crate is standalone. It declares all its dependencies directly and doesn't rely on any workspace-level config, so removing it from the workspace doesn't affect the wasm-pack build in CI.
Fixes #40