chore: move test/dev dependencies from extras to dependency groups#33
Open
g4bri3lDev wants to merge 1 commit into
Open
chore: move test/dev dependencies from extras to dependency groups#33g4bri3lDev wants to merge 1 commit into
g4bri3lDev wants to merge 1 commit into
Conversation
Extras are not installed by a plain `uv run`, so `uv run pytest` fell back to any pytest on PATH, testing against whatever odl_renderer that interpreter could import instead of the current tree. As dependency groups (dev includes test), they are synced by default. The visual and property extras stay extras: they gate optional test suites. lint.yml switches from `uv sync --extra dev` to plain `uv sync`, which installs the dev group by default.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same change as OpenDisplay/py-opendisplay#112:
testanddevlived in[project.optional-dependencies](extras). Extras are not installed by a plainuv run, souv run pytestin a fresh checkout or worktree silently fell back to whatever pytest is on $PATH — running tests under a different interpreter against whateverodl_rendererthat interpreter could import, instead of the tree under test. Dev tooling is also not publishable package metadata, so[dependency-groups]is the semantically right home.testanddevmoved to[dependency-groups];devincludestestvisualandpropertystay extras — they gate optional test suites, and the visual tests importimagehash/syrupyunconditionally, so the full suite still needs--all-extras(unchanged)lint.yml:uv sync --extra dev→uv sync(the dev group is installed by default; the extra no longer exists)test.yml/generate-screenshots.ymluv sync --all-extraskeep working (dev group is default)uv lockalso refreshed the lockfile's stale self-version (0.5.10 → 0.5.11, pyproject was already bumped)Test plan
uv run --all-extras pytest -q→ 402 passed (pytest resolved from.venv, not PATH)uv lockresolves🤖 Generated with Claude Code