feat: honor partial_update_support=2 (full-frame partial stream)#116
Open
g4bri3lDev wants to merge 1 commit into
Open
feat: honor partial_update_support=2 (full-frame partial stream)#116g4bri3lDev wants to merge 1 commit into
g4bri3lDev wants to merge 1 commit into
Conversation
The config tool now defines partial_update_support value 2: partial updates supported but the stream must cover the whole panel, because firmware white-fills the controller RAM at partial start and on these panels (e.g. EP426 / Seeed EN05) the partial waveform erases everything the stream does not cover (OpenDisplay/Firmware#80). compute_partial_region expands the region to the full panel for such displays after diffing (no_change detection unaffected), so uploads stay flicker-free with no caller changes. New PartialUpdateSupport IntEnum exported from the package root.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the client side of the new signaling from OpenDisplay/Firmware#80: the config tool now defines
partial_update_support: 2— partial updates supported but full-frame stream required — for panels where the firmware's white-fill at partial START would erase content outside the region (hardware-confirmed on EP426 / Seeed EN05).compute_partial_regionexpands the region to the whole panel when the display signals2, after normal diffing —no_changedetection still skips identical frames, fallbacks unchanged, callers need no changesPartialUpdateSupportIntEnum (NONE/PARTIAL/FULL_FRAME), exported from the package root1on affected panels)The full-frame partial path is the one hardware-verified on the EN05 (fw 2.0): flicker-free, correct across a 5-cycle dashboard test, ~7 KB compressed wire per update.
Test plan
FULL_FRAMEexpands rect to panel size;1keeps the minimal 8-aligned rect;no_changestill short-circuits onFULL_FRAMEpanelspytest -q→ 497 passed; prek hooks clean🤖 Generated with Claude Code