Skip to content

remove unused command fetch rbfe-showcase - #1732

Merged
atravitz merged 2 commits into
mainfrom
maint/remove-unused-fetch
Dec 4, 2025
Merged

remove unused command fetch rbfe-showcase#1732
atravitz merged 2 commits into
mainfrom
maint/remove-unused-fetch

Conversation

@atravitz

@atravitz atravitz commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

currently we don't even show rbfe-showcase as an option:

> openfe fetch -h

  Fetch the given resource. Some resources require internet; others are built-
  in.

Options:
  -h, --help  Show this message and exit.

Tutorials Commands:
  rbfe-tutorial          CLI and Python tutorial on relative binding free
                         energies [requires internet]
  rbfe-tutorial-results  Results package to follow-up the rbfe-tutorial

And we just removed these unused files from ExampleNotebooks: OpenFreeEnergy/ExampleNotebooks#269

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz
atravitz requested a review from IAlibay December 3, 2025 22:42
@atravitz
atravitz enabled auto-merge (squash) December 3, 2025 22:45
@github-actions

github-actions Bot commented Dec 3, 2025

Copy link
Copy Markdown

No API break detected ✅

@codecov

codecov Bot commented Dec 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.15%. Comparing base (f491184) to head (17c77fa).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1732      +/-   ##
==========================================
- Coverage   95.47%   93.15%   -2.32%     
==========================================
  Files         187      187              
  Lines       16244    16240       -4     
==========================================
- Hits        15509    15129     -380     
- Misses        735     1111     +376     
Flag Coverage Δ
fast-tests 93.15% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz
atravitz merged commit b57d3e1 into main Dec 4, 2025
13 checks passed
@atravitz
atravitz deleted the maint/remove-unused-fetch branch December 4, 2025 00:07
@atravitz atravitz mentioned this pull request Dec 4, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants