Skip to content

[com1]: add saving option for resistance fields#1290

Merged
fso42 merged 1 commit into
masterfrom
addResFields
Jun 15, 2026
Merged

[com1]: add saving option for resistance fields#1290
fso42 merged 1 commit into
masterfrom
addResFields

Conversation

@awirb

@awirb awirb commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@awirb awirb requested a review from fso42 June 8, 2026 09:23
@awirb awirb self-assigned this Jun 8, 2026
@qltysh

qltysh Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.07%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA75.0%

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py68.4%1328-1329, 2474-2483
Coverage rating: A Coverage rating: A
avaframe/com1DFA/com1DFATools.py100.0%
Total75.0%
🤖 Increase coverage with AI coding...
In the `addResFields` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Lines 1328-1329 and 2474-2483

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@fso42 fso42 added the enhancement New feature or request label Jun 10, 2026
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
@awirb awirb requested a review from fso42 June 11, 2026 14:38
@awirb awirb changed the title add saving option for resistance fields [com1]: add saving option for resistance fields Jun 12, 2026
@fso42 fso42 assigned fso42 and unassigned awirb Jun 12, 2026
add simname to name

move outside if, add log.info

change name from orig to track

adjust tests

test(com1DFA): add resistance initialization tests with raster export

- Added comprehensive tests for initializing resistance with raster inputs, including raster export validation.
- Verified creation of output raster files with appropriate naming conventions.
@fso42

fso42 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Standardtests ident (apart from known com5)

@fso42 fso42 merged commit db928ea into master Jun 15, 2026
4 checks passed
@fso42 fso42 deleted the addResFields branch June 15, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants