[com1]: make deposition erodable (initially)

[PaulaSp3]

• add an option that deposition is entrainable: (if ent in simTypeList, adaptSfcStopped = 1, adaptSfcEntrainment = 1, entrainableDeposition = True)

  erodible layer:
  ($h_{entrainable}$ ist die Höhe, nicht Mächtigkeit!!!)

  before simulation:
  $dem_{notEntrainable} = dem_{orig} - h_{entrainable}(t=0)$

  $dem_{sim}(t=0) = dem_{orig}$

  for every timestep t and for every grid cell:

  $h_{entrainable}(t) = h_{entrainable}(t=0) + \sum_{i=0}^{t}(h_{dep}(i) - h_{ero}(i))$

  $m_{entrainable}(t) = m_{entrainable}(t=0) + thickness_{entrainable}(t) * \rho - dm_{ero}(t-1)$

  $dem_{sim}(t) = dem_{notEntrainable} + h_{entrainable}(t)$

  ($\rho$: density of flowing material, $thickness$ is derived from $h$ and slope)

  closes Do we need on top of the topography an erodible layer? DebrisFrame#68
  closes make deposited material erodible DebrisFrame#69

  there are still a many open questions:
  [com1]: improve adaptable topography DebrisFrame#66

• fixes bugs, when using timedependent release and entrainment:
  closes Test all variations (ent, res, sec release) with time dependent release DebrisFrame#74

[qltysh]

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.11%.

Modified Components (1)

Rating	Component	% Diff
	com1DFA	75.0%

Modified Files with Diff Coverage (4)

Rating	File	% Diff	Uncovered Line #s
	avaframe/com1DFA/com1DFA.py	76.7%	1312, 3462-3466...
	avaframe/out3Plot/plotUtils.py	100.0%
	avaframe/com1DFA/deriveParameterSet.py	50.0%	906
	avaframe/in3Utils/geoTrans.py	100.0%
	Total	89.7%

🤖 Increase coverage with AI coding...

In the `PS_addErodibleLayer` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Lines 1312, 3462-3466, and 3883-3886
- `avaframe/com1DFA/deriveParameterSet.py` -- Line 906

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[awirb]

this is a nested logic - is there a check and error message if it is true but the others are False?

[PaulaSp3]

is it better to raise an error or to set entrainableDeposition to False in this case (as it is done in com1DFA.py line 3464)?