Nhse o40 orkv.i141 silvermachine#3
Open
martinsumner wants to merge 83 commits into
Open
Conversation
WIP. A framework of modules and functions for SliverMachine.
Apply only to new files, or heavily altered files so that broader change history is maintained.
Also add callback module and unit test the sending of responses both streamed and whole.
Plus some further testing/formatting
Retain mohijson2 and mochinum to ease transition
Where URI starts "/" will add a leading <<>> to the split path - which is confusing and easy to forget about.
Address initial feedback
Also provides functions for converting Last Modified Date in KV GET.
No intention to support trailer fields. Cannot merge with headers, as headers already processed by callback. Actually looking at trailer fields provides further risk (how many should be supported, should they be included in content size etc).
hmmr
requested changes
May 14, 2026
hmmr
left a comment
There was a problem hiding this comment.
Overall, designing this riak component as a pared-down http server, with no attempt to present it as a general purpose http server outside of riak, is clearly the right approach. A handful of non-critical issues; otherwise, ready to approve.
Handle different error scenarios
hmmr
approved these changes
May 18, 2026
Add a regression test for the empty acceptor pool case after max pool use and worker exits. Register the new module in the erlfmt file list.
Only decode after splitting, and return halt errors on decode failures
WarpEngineer
approved these changes
May 26, 2026
Property for splitting paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch HTTP API to use SilverMachine not WebMachine/Mochiweb.
Intentions are: