Skip to content

security(dci): scope notification delivery per subscriber (consent + filter)#258

Open
gonzalesedwin1123 wants to merge 3 commits into
19.0from
security-dci-notify-pii
Open

security(dci): scope notification delivery per subscriber (consent + filter)#258
gonzalesedwin1123 wants to merge 3 commits into
19.0from
security-dci-notify-pii

security(dci): fail closed on missing filter_type (staff-review fix)

7465ae5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 29, 2026 in 1s

75.23% (+0.48%) compared to f04d936

View this Pull Request on Codecov

75.23% (+0.48%) compared to f04d936

Details

Codecov Report

❌ Patch coverage is 88.34951% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.23%. Comparing base (f04d936) to head (7465ae5).

Files with missing lines Patch % Lines
...ci_server_social/models/dci_subscription_social.py 85.45% 8 Missing ⚠️
spp_dci_server/models/subscription.py 89.74% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0     #258      +/-   ##
==========================================
+ Coverage   74.75%   75.23%   +0.48%     
==========================================
  Files        1090     1093       +3     
  Lines       64813    64954     +141     
==========================================
+ Hits        48453    48871     +418     
+ Misses      16360    16083     -277     
Files with missing lines Coverage Δ
spp_dci_server/routers/async_router.py 92.39% <ø> (ø)
spp_dci_server_social/models/__init__.py 100.00% <100.00%> (ø)
...dci_server_social/models/res_partner_dci_notify.py 91.35% <100.00%> (+7.68%) ⬆️
spp_dci_server/models/subscription.py 91.70% <89.74%> (-0.65%) ⬇️
...ci_server_social/models/dci_subscription_social.py 85.45% <85.45%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.