Skip to content

Complete gesture view modifier support#905

Open
Kyle-Ye wants to merge 9 commits into
mainfrom
feature/tap_gestures
Open

Complete gesture view modifier support#905
Kyle-Ye wants to merge 9 commits into
mainfrom
feature/tap_gestures

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Implement gesture view modifier responder wiring for masked view gestures, subview gesture propagation, and debug wrapping.
  • Add simultaneous and high-priority gesture modifier/combiners, plus optional gesture support.
  • Add public View gesture overloads for GestureMask, isEnabled, and named gestures with DocC.
  • Add gesture debug tree formatting coverage and compatibility tests.

@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability. labels Jun 10, 2026
@Kyle-Ye Kyle-Ye marked this pull request as ready for review June 10, 2026 19:03

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 205 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.98%. Comparing base (cf9a0d4) to head (ca71b82).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...wiftUICore/Event/Gesture/GestureViewModifier.swift 0.00% 96 Missing ⚠️
...s/OpenSwiftUICore/Event/Gesture/GestureDebug.swift 36.19% 67 Missing ⚠️
...es/OpenSwiftUICore/Event/Gesture/GestureMask.swift 0.00% 30 Missing ⚠️
...penSwiftUICore/Event/Gesture/OptionalGesture.swift 0.00% 10 Missing ⚠️
Sources/OpenSwiftUICore/Util/AnyAttributeFix.swift 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cf9a0d4) and HEAD (ca71b82). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cf9a0d4) HEAD (ca71b82)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #905       +/-   ##
===========================================
- Coverage   26.28%   13.98%   -12.31%     
===========================================
  Files         710      669       -41     
  Lines       49705    43702     -6003     
===========================================
- Hits        13063     6110     -6953     
- Misses      36642    37592      +950     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant