feat: add accessibility labels to torch and cancel buttons#55
Open
alexgerardojacinto wants to merge 5 commits into
Open
feat: add accessibility labels to torch and cancel buttons#55alexgerardojacinto wants to merge 5 commits into
alexgerardojacinto wants to merge 5 commits into
Conversation
The torch and cancel buttons were icon-only with no alternative text, so screen readers could not announce them. Add default English content descriptions and expose optional cancelButtonAccessibilityLabel, torchButtonOnAccessibilityLabel and torchButtonOffAccessibilityLabel scan parameters so consumers can customize/localize them. Closes #54
12 tasks
When a label is not provided (null/blank), no content description is set, keeping the previous behavior unchanged. The English default labels are removed; consumers supply the (localized) labels via the scan parameters.
Open
10 tasks
alexgerardojacinto
requested review from
ItsChaceD,
OS-ruimoreiramendes,
andredestro,
capacitor-bot,
jcesarmobile,
markemer and
theproducer
and removed request for
a team
Not being used these days, might as well comment to see if CI passes
Comment on lines
+17
to
+19
| @SerializedName("cancelButtonAccessibilityLabel") val cancelButtonAccessibilityLabel: String? = null, | ||
| @SerializedName("torchButtonOnAccessibilityLabel") val torchButtonOnAccessibilityLabel: String? = null, | ||
| @SerializedName("torchButtonOffAccessibilityLabel") val torchButtonOffAccessibilityLabel: String? = null |
Collaborator
There was a problem hiding this comment.
Should add these parameters to the README, as we have done before?
I didn't do it myself because I was a bit confused on a portion of the sentence you use to describe them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Torch and Cancel buttons are icon-only with no alternative text, so screen readers can't announce them. This PR adds the ability to set that alternative text.
cancelButtonAccessibilityLabeltorchButtonOnAccessibilityLabel(torch on)torchButtonOffAccessibilityLabel(torch off)Context
An accessibility audit flagged that the Torch and Cancel buttons have no alternative text, so they are announced incorrectly by screen readers. This exposes the labels as inputs so consumers can provide localized alternative text.
Closes #54
Type of changes
Platforms affected
Tests
Screenshots (if appropriate)
N/A
Checklist