fix: prevent Expanded Dark Theme inversion on scanner activity#56
Open
OS-pedrogustavobilro wants to merge 4 commits into
Open
fix: prevent Expanded Dark Theme inversion on scanner activity#56OS-pedrogustavobilro wants to merge 4 commits into
OS-pedrogustavobilro wants to merge 4 commits into
Conversation
Adds an AppCompat DayNight theme to `OSBARCScannerActivity` so Android does not treat it as a legacy light-themed app and invert its colors when Expanded Dark Theme is enabled. References: https://outsystemsrd.atlassian.net/browse/RMET-5280
Might be 2.1.0 instead if we bundle with #55; depends on merge order / time.
Not being used these days, might as well comment to see if CI passes
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
capacitor-bot,
eric-horodyski,
markemer and
theproducer
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an AppCompat DayNight theme to
OSBARCScannerActivityso Android does not treat it as a legacy light-themed activity and invert its colors when Expanded Dark Theme is enabled.In this PR I also do a few housekeeping changes like updating PR template and commenting SonarCloud template because it was failing CI and we're not really using it atm.
Context
Expanded Dark Theme is an accessibility feature added in Android 16.1, that when enabled, was causing the scanning screen to have a white tint, because (without this fix) it was assuming the screen was not in dark mode, therefore (wrongfully) inverting the colors.
Internal jira Reference: https://outsystemsrd.atlassian.net/browse/RMET-5280
Type of changes
Tests
I tested OutSystems Sample apps (O11 with Cordova and ODC with Capacitor). If you'd like to test yourself, refer to the following apk files in this drive folder ("before" for without this PR, "after" for with this PR): https://drive.google.com/drive/folders/1PeI7udQya5Ad4cMBTNXP0jPfUgOpenuF?usp=sharing
Screenshots (if appropriate)
The following are screenshots on a Pixel device with Android 17 and Expanded Dark Theme enabled in device settings.
Checklist