fix(ci): public launch smoke fails closed without URL/token - #234
Merged
Conversation
tools/public_launch_smoke.py main() previously exited 0 when LEDGER_SMOKE_BASE_URL was absent and printed SKIP (still exit 0) when LEDGER_SMOKE_ADMIN_TOKEN was missing — a scheduled smoke run could be green without smoking anything, and the workflow never asserted the secrets were present. - main() now returns 1 with RESULT=FAIL when either variable is unset (the authenticated contracts are part of the scheduled smoke; a missing token is a configuration failure, not a reason to skip half the contract). - public-smoke.yml gains a pre-step asserting both secrets are configured, with a clear ::error:: message. - tests/test_public_launch_smoke.py extended with main() unit tests: missing URL, missing token, transport failure, bad status, success. - Actions pinned to commit SHAs while in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #230 (filed from the 2026-08-11 test-suite + CI audit).
tools/public_launch_smoke.pyexited 0 whenLEDGER_SMOKE_BASE_URLwasabsent and printed SKIP (still exit 0) when
LEDGER_SMOKE_ADMIN_TOKENwasmissing — a scheduled smoke run could be green without smoking anything, and
the workflow never asserted the secrets were present.
main()returns 1 withRESULT=FAILwhen either variable is unset. Theauthenticated contracts are part of the scheduled smoke; a missing token is
a configuration failure, not a reason to skip half the contract.
public-smoke.ymlgains a pre-step asserting both secrets are configured(clear
::error::messages at the workflow level).tests/test_public_launch_smoke.pyextended withmain()unit tests:missing URL, missing token, transport failure, bad status, success.
Local verification: full suite green (711 passed incl. 5 new
main()tests, 70.69% coverage).