Group raphtory-tests into fewer binaries#2647
Merged
Merged
Conversation
…s us to generate the other different graphs
# Conflicts: # raphtory-tests/tests/test_filters.rs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 067b64c | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
3 ns/iter (± 0) |
1 ns/iter (± 0) |
3 |
lotr_graph/graph_latest |
2 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
6377232 ns/iter (± 40027) |
1564816 ns/iter (± 35303) |
4.08 |
lotr_graph_window_100_materialise/materialize |
6241923 ns/iter (± 31162) |
1669150 ns/iter (± 10700) |
3.74 |
lotr_graph_window_10_materialise/materialize |
2584780 ns/iter (± 11701) |
971980 ns/iter (± 4278) |
2.66 |
lotr_graph_subgraph_10pc_materialise/materialize |
1536867 ns/iter (± 18243) |
334634 ns/iter (± 1287) |
4.59 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
935999 ns/iter (± 10825) |
230399 ns/iter (± 2617) |
4.06 |
lotr_graph_window_50_layered/has_node_existing |
331 ns/iter (± 19) |
129 ns/iter (± 12) |
2.57 |
lotr_graph_window_50_layered_materialise/materialize |
25197879 ns/iter (± 195642) |
3488825 ns/iter (± 24948) |
7.22 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
520280 ns/iter (± 5410) |
192686 ns/iter (± 1569) |
2.70 |
lotr_graph_persistent_window_50_layered/graph_latest |
122182 ns/iter (± 1497) |
57549 ns/iter (± 4809) |
2.12 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
42700304 ns/iter (± 252400) |
5298035 ns/iter (± 147912) |
8.06 |
This comment was automatically generated by workflow using github-action-benchmark.
# Conflicts: # raphtory-tests/tests/cached_view.rs # raphtory-tests/tests/test_filters.rs # raphtory/src/db/graph/views/filter/model/degree_filter.rs
fabubaker
requested changes
Jul 7, 2026
fabubaker
left a comment
fabubaker
left a comment
Contributor
There was a problem hiding this comment.
Need to add back some missing tests.
Please change the PR title to be more descriptive, for eg, "Group raphtory-tests into fewer binaries"
arienandalibi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Group test files based on test contents. By grouping them into folders, we make multiple test files compile into a single "crate" (binary). This saves us time when building because, for each single test file not in a folder, a whole binary is built, and this binary needs to link all of raphtory and its associated crates. By limiting the number of binaries, we also limit this overhead.
Why are the changes needed?
Faster build times
Does this PR introduce any user-facing change? If yes is this documented?
No
How was this patch tested?
All the tests are still run and still pass
Are there any further changes required?
No