Add vectors feature to raphtory-graphql#2671
Open
fabianmurariu wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 0cb7089 | Previous: 9823ef7 | Ratio |
|---|---|---|---|
lotr_graph/num_edges |
4 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph/num_nodes |
4 ns/iter (± 0) |
1 ns/iter (± 0) |
4 |
lotr_graph/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph/graph_latest |
3 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
lotr_graph_materialise/materialize |
7692903 ns/iter (± 33328) |
1564816 ns/iter (± 35303) |
4.92 |
lotr_graph_window_100/num_nodes |
14 ns/iter (± 1) |
5 ns/iter (± 0) |
2.80 |
lotr_graph_window_100_materialise/materialize |
7773659 ns/iter (± 41673) |
1669150 ns/iter (± 10700) |
4.66 |
lotr_graph_window_10/has_node_existing |
135 ns/iter (± 10) |
62 ns/iter (± 11) |
2.18 |
lotr_graph_window_10_materialise/materialize |
3284453 ns/iter (± 13940) |
971980 ns/iter (± 4278) |
3.38 |
lotr_graph_subgraph_10pc/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_subgraph_10pc_materialise/materialize |
1999388 ns/iter (± 10534) |
334634 ns/iter (± 1287) |
5.97 |
lotr_graph_subgraph_10pc_windowed/has_node_existing |
141 ns/iter (± 9) |
62 ns/iter (± 14) |
2.27 |
lotr_graph_subgraph_10pc_windowed_materialise/materialize |
1239515 ns/iter (± 12095) |
230399 ns/iter (± 2617) |
5.38 |
lotr_graph_window_50_layered/num_edges_temporal |
143003 ns/iter (± 5432) |
70121 ns/iter (± 7586) |
2.04 |
lotr_graph_window_50_layered/has_node_existing |
395 ns/iter (± 21) |
129 ns/iter (± 12) |
3.06 |
lotr_graph_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_window_50_layered/graph_latest |
82616 ns/iter (± 2024) |
36649 ns/iter (± 916) |
2.25 |
lotr_graph_window_50_layered_materialise/materialize |
28898108 ns/iter (± 185952) |
3488825 ns/iter (± 24948) |
8.28 |
lotr_graph_persistent_window_50_layered/num_edges_temporal |
581234 ns/iter (± 7767) |
192686 ns/iter (± 1569) |
3.02 |
lotr_graph_persistent_window_50_layered/has_node_existing |
419 ns/iter (± 371) |
174 ns/iter (± 83) |
2.41 |
lotr_graph_persistent_window_50_layered/has_node_nonexisting |
5 ns/iter (± 0) |
2 ns/iter (± 0) |
2.50 |
lotr_graph_persistent_window_50_layered/graph_latest |
130402 ns/iter (± 2082) |
57549 ns/iter (± 4809) |
2.27 |
lotr_graph_persistent_window_50_layered_materialise/materialize |
49100704 ns/iter (± 138567) |
5298035 ns/iter (± 147912) |
9.27 |
This comment was automatically generated by workflow using github-action-benchmark.
fabubaker
approved these changes
Jul 7, 2026
fabubaker
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just had a question about the docs.
Comment on lines
-7906
to
-7910
| A working set of documents / nodes / edges built up via similarity | ||
| searches on a `VectorisedGraph`. Selections are mutable: you can grow | ||
| them with more hops (`expand*`), dereference the contents (`nodes`, | ||
| `edges`, `getDocuments`), or start fresh with `emptySelection`. | ||
|
|
Contributor
There was a problem hiding this comment.
Is it ok for these docs to not be there anymore? cc @ricopinazo @miratepuffin
| decimal: String | ||
| } | ||
|
|
||
| """ |
Contributor
There was a problem hiding this comment.
Ditto for these schema docs not being present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?