feat: Upgrade Claude adapter to SDK 0.3 with native binary#2385
Open
charlesvien wants to merge 4 commits into
Open
feat: Upgrade Claude adapter to SDK 0.3 with native binary#2385charlesvien wants to merge 4 commits into
charlesvien wants to merge 4 commits into
Conversation
Contributor
What T-Rex did
ArtifactsComprehensive proof-of-work results
Local command marker stripping checks
Reviews (1): Last reviewed commit: "harden native claude binary packaging fo..." | Re-trigger Greptile |
| const filtered: SessionConfigSelectOption[] = []; | ||
| const seen = new Set<string>(); | ||
|
|
||
| for (const entry of allowlist) { |
Contributor
There was a problem hiding this comment.
applyAvailableModelsAllowlist was checked with a gateway default of claude-opus-4-7 and...
- Bug
- applyAvailableModelsAllowlist was checked with a gateway default of claude-opus-4-7 and availableModels: "claude-haiku-4-5".
- The returned model options dropped the gateway Default option entirely.
- The returned currentModelId changed to the first allowlisted model instead of preserving the default/current model.
- This contradicts the function comment and Claude Code behavior that the Default model remains available even when availableModels is configured.
- Cause
- T-Rex reproduced this while running the changed behavior, but it did not return a separate root-cause sentence.
- Fix
- Update the changed code so this failing path is handled, then rerun the same T-Rex check to confirm it passes.
Artifacts
availableModels allowlist repro
- Keeps the command output available without making the summary code-heavy.
Generated allowlist repro script
- Contains supporting evidence from the run (text/javascript; charset=utf-8).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
It's that time of the month again, claude adapter update! We pinned the adapter to SDK 0.2.112 for awhile because 0.2.114 broke session init; meanwhile upstream shipped Task tools, MCP changes and ACP 0.22. Lots of bug fixes + supposed session initialization timing improvements being adopted.
Changes
resumeSessionAPI (wasunstable_resumeSession) for ACP 0.22MCP_CONNECTION_NONBLOCKING=0so MCP servers stay blocking-connect and tools are ready on first promptHow did you test this?
Manually
Publish to changelog?
no