Skip to content

fix: satisfy SDK compliance harness 0.8.0#200

Merged
marandaneto merged 4 commits into
mainfrom
sdk-harness-audit-20260627-posthog-ruby
Jun 30, 2026
Merged

fix: satisfy SDK compliance harness 0.8.0#200
marandaneto merged 4 commits into
mainfrom
sdk-harness-audit-20260627-posthog-ruby

Conversation

@marandaneto

@marandaneto marandaneto commented Jun 27, 2026

Copy link
Copy Markdown
Member

Problem

The SDK compliance workflow and local harness need to use SDK test harness release 0.8.0, with reusable GitHub workflow calls pinned to the release commit SHA instead of a mutable tag/branch. Running the updated harness exposed SDK/adapter compliance gaps in this repository.

Changes

  • Pins the reusable SDK compliance workflow to PostHog/posthog-sdk-test-harness commit be8b8d5a3f94a249659844e94832e874f049c1e4.\n- Uses ghcr.io/posthog/sdk-test-harness:0.8.0 for local Docker harness runs / workflow harness version inputs.\n- Updates SDK compliance adapter and/or SDK behavior needed to pass the 0.8.0 compliance contract.

Tests

  • SDK compliance Docker harness passed locally with project posthog_ruby_compliance (45/45).

@marandaneto marandaneto changed the title chore: add SDK compliance harness 0.8.0 fix: satisfy SDK compliance harness 0.8.0 Jun 27, 2026
@github-actions

github-actions Bot commented Jun 27, 2026

Copy link
Copy Markdown

posthog-ruby Compliance Report

Date: 2026-06-29 14:19:47 UTC
Duration: 97877ms

✅ All Tests Passed!

45/45 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 9ms
Format Validation.Event Has Uuid 105ms
Format Validation.Event Has Lib Properties 110ms
Format Validation.Distinct Id Is String 107ms
Format Validation.Token Is Present 106ms
Format Validation.Custom Properties Preserved 106ms
Format Validation.Event Has Timestamp 109ms
Retry Behavior.Retries On 503 5310ms
Retry Behavior.Does Not Retry On 400 2109ms
Retry Behavior.Does Not Retry On 401 2109ms
Retry Behavior.Respects Retry After Header 8116ms
Retry Behavior.Implements Backoff 15523ms
Retry Behavior.Retries On 500 5213ms
Retry Behavior.Retries On 502 5212ms
Retry Behavior.Retries On 504 5212ms
Retry Behavior.Max Retries Respected 15613ms
Deduplication.Generates Unique Uuids 112ms
Deduplication.Preserves Uuid On Retry 5212ms
Deduplication.Preserves Uuid And Timestamp On Retry 10418ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5215ms
Deduplication.No Duplicate Events In Batch 112ms
Deduplication.Different Events Have Different Uuids 107ms
Compression.Sends Gzip When Enabled 106ms
Batch Format.Uses Proper Batch Structure 107ms
Batch Format.Flush With No Events Sends Nothing 4ms
Batch Format.Multiple Events Batched Together 109ms
Error Handling.Does Not Retry On 403 2109ms
Error Handling.Does Not Retry On 413 2108ms
Error Handling.Retries On 408 5212ms

Feature_Flags Tests

16/16 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 109ms
Request Payload.Flags Request Uses V2 Query Param 109ms
Request Payload.Flags Request Hits Flags Path Not Decide 109ms
Request Payload.Flags Request Omits Authorization Header 107ms
Request Payload.Token In Flags Body Matches Init 107ms
Request Payload.Groups Round Trip 107ms
Request Payload.Groups Default To Empty Object 107ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 107ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 107ms
Request Payload.Disable Geoip Omitted Defaults To False 107ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 108ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 105ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 110ms
Request Lifecycle.Mock Response Value Is Returned To Caller 105ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 109ms

@greptile-apps

greptile-apps Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "chore: add SDK compliance harness 0.8.0" | Re-trigger Greptile

Comment thread lib/posthog/transport.rb
Comment thread lib/posthog/transport.rb Outdated
Comment thread spec/posthog/send_worker_spec.rb Outdated
@marandaneto marandaneto marked this pull request as ready for review June 29, 2026 14:07
@marandaneto marandaneto requested a review from a team as a code owner June 29, 2026 14:07
@marandaneto

Copy link
Copy Markdown
Member Author

i need to merge #202 first since i already added gzip support

@marandaneto marandaneto mentioned this pull request Jun 29, 2026
5 tasks
@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Reviews (2): Last reviewed commit: "fix retry-after handling in transport" | Re-trigger Greptile

…60627-posthog-ruby

# Conflicts:
#	lib/posthog/client.rb
#	lib/posthog/send_worker.rb
#	lib/posthog/transport.rb
@marandaneto marandaneto merged commit caa245a into main Jun 30, 2026
18 checks passed
@marandaneto marandaneto deleted the sdk-harness-audit-20260627-posthog-ruby branch June 30, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants