Skip to content

ci: Configure SDK compliance capture suite#203

Closed
marandaneto wants to merge 1 commit into
mainfrom
fix/sdk-harness-options-20260630
Closed

ci: Configure SDK compliance capture suite#203
marandaneto wants to merge 1 commit into
mainfrom
fix/sdk-harness-options-20260630

Conversation

@marandaneto

Copy link
Copy Markdown
Member

Problem

SDK compliance workflows need explicit harness suite/sdk-type selection and configurable blocking behavior so CI only runs the intended contract checks.

Changes

  • Point SDK compliance to the harness branch with new workflow inputs.
  • Run capture v0 as a server SDK.
  • Keep compliance failures non-blocking for now.
  • Align local compose with the same suite/sdk type.

Testing

  • Parsed workflow YAML.
  • Ran docker compose config for the adapter compose file.
  • Ran git diff --check.

Release / changeset

No SDK package changeset: CI/local compliance configuration only.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented with Pi using dedicated git worktrees. The change was requested to align SDK compliance harness setup across SDK repositories while keeping non-ready SDKs non-blocking.

@marandaneto marandaneto self-assigned this Jun 30, 2026
@greptile-apps

greptile-apps Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "ci: Configure SDK compliance capture sui..." | Re-trigger Greptile

compliance:
name: PostHog SDK compliance tests
uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@be8b8d5a3f94a249659844e94832e874f049c1e4
uses: PostHog/posthog-sdk-test-harness/.github/workflows/test-sdk-action.yml@fix/sdk-harness-options-20260630

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Mutable branch reference in reusable workflow call

The uses line was changed from a pinned commit SHA to a branch name (fix/sdk-harness-options-20260630). Branch references are mutable: any push to that branch in the external posthog-sdk-test-harness repo will immediately affect what code runs inside this workflow, including in a security context with access to secrets. If the branch is ever force-pushed or receives an unreviewed commit, CI will silently pick it up. This also makes the build non-reproducible — the same workflow run could behave differently on different days.

Once the harness branch is merged, this should be updated to either the merge commit SHA or the next tagged release SHA.

@github-actions

Copy link
Copy Markdown

posthog-ruby Compliance Report

Date: 2026-06-30 10:01:25 UTC
Duration: 96668ms

✅ All Tests Passed!

29/29 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 10ms
Format Validation.Event Has Uuid 105ms
Format Validation.Event Has Lib Properties 109ms
Format Validation.Distinct Id Is String 107ms
Format Validation.Token Is Present 108ms
Format Validation.Custom Properties Preserved 107ms
Format Validation.Event Has Timestamp 108ms
Retry Behavior.Retries On 503 5415ms
Retry Behavior.Does Not Retry On 400 2109ms
Retry Behavior.Does Not Retry On 401 2109ms
Retry Behavior.Respects Retry After Header 8117ms
Retry Behavior.Implements Backoff 15722ms
Retry Behavior.Retries On 500 5212ms
Retry Behavior.Retries On 502 5212ms
Retry Behavior.Retries On 504 5212ms
Retry Behavior.Max Retries Respected 15712ms
Deduplication.Generates Unique Uuids 112ms
Deduplication.Preserves Uuid On Retry 5212ms
Deduplication.Preserves Uuid And Timestamp On Retry 10419ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5214ms
Deduplication.No Duplicate Events In Batch 112ms
Deduplication.Different Events Have Different Uuids 107ms
Compression.Sends Gzip When Enabled 106ms
Batch Format.Uses Proper Batch Structure 108ms
Batch Format.Flush With No Events Sends Nothing 4ms
Batch Format.Multiple Events Batched Together 111ms
Error Handling.Does Not Retry On 403 2108ms
Error Handling.Does Not Retry On 413 2109ms
Error Handling.Retries On 408 5212ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant