fix: use CultureInfo ctor instead of Get-Culture -Name for PS5.1 compat#462
Merged
Conversation
Test Results 4 files 284 suites 1m 11s ⏱️ For more details on these failures, see this check. Results for commit 570ae9a. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #459
Summary
Get-Culture -Namewas added in PS6; on PS5.1 it throws a parameter binding errortests/Get-PlasterManifestPathForCulture.Tests.ps1withNew-Object System.Globalization.CultureInfo("en-US"), matching the pattern already used by the other two tests in the same fileTest plan
Get-PlasterManifestPathForCulture"returns the manifest for the specified culture" passes🤖 Generated with Claude Code