fix: normalise xmlns attribute placement in New-PlasterManifest for PS5.1#464
Merged
Conversation
…S5.1 compat (#461) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Test Results 4 files 284 suites 1m 1s ⏱️ For more details on these failures, see this check. Results for commit c9573e0. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #461
Summary
XmlWriterSettings.NewLineOnAttributesfor namespace declarations, emittingxmlnsinline instead of on its own indented line$xmlWriter.Dispose(), reads the written file back and applies a regex substitution to move an inlinexmlns=attribute onto its own line, matching the format the tests expect$wroteFileflag gates the post-processing so it only runs whenShouldProcessreturned true (skipped in-WhatIfmode)Test plan
New-PlasterManifest"Generates a valid manifest" tests pass🤖 Generated with Claude Code