Task/283 use classes to reduce extern and globals - #598
Open
nk25719 wants to merge 21 commits into
Open
Conversation
- Necessary libraries have been added and are tracked in the 'platform.ini' file
- Moved WiFiManager and ElegantOTA libraries to the bottom of the list - Clean builds failed during first compilation due to libraries depending on other libraries not build yet
- The baud rate with PlatformIO defaults to 9800 - The correct baud rate for the serial connection with the ESP32-WROOM is 115200
- The defines in `gpad_utility.h` are still defined in the file for completeness - The values are empty since the values are now fed in via a pre-build script - The benefit of this is that to change the values of the defines does not require modifying a source file - The values, like the firmware version and product name, can now be provided programmatically - Like pulling a version from git tag - A static config file with the values
- Changes include linking to instructions for installing the PIO CLI tools and setting up the shell commands - Instructions for building the LittleFS filesystem
- PlatformIO recommends listing a specific version for packages (and platforms) and preceding the '@' with a '^' (caret) so the latest compatible version will be used - The "tip" is in a blue box under this section: https://docs.platformio.org/en/latest/core/userguide/pkg/cmd_install.html#id17
- GPAD_API_VERSION is now defined as a preprocessor directive, like FIRMWARE_VERSION - The value is published via MQTT just like the FIRMWARE_VERSION
…ment - The GPAD API version is now hardcoded as an actual value - It is not something that should be able to be changed by a compilation flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective of this PR: examine changes done in branch.