timedelta: support microseconds and negative values - #795
Open
methane wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
==========================================
+ Coverage 88.86% 90.66% +1.79%
==========================================
Files 7 7
Lines 548 557 +9
==========================================
+ Hits 487 505 +18
+ Misses 61 52 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates MySQLdb’s timedelta string formatting to correctly handle negative values and to include microseconds, aligning both literal conversion and formatting behavior with MySQL’s expected TIME literal semantics.
Changes:
- Fix
format_TIMEDELTAto render negative timedeltas with a single leading sign and an absolute-value day/time component (avoids MySQL interpreting a “double-negative”). - Extend
format_TIMEDELTAoutput to include fractional seconds whentimedelta.microsecondsis non-zero. - Expand/adjust tests to cover negative timedeltas and microsecond precision, and update an existing negative-case expectation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_MySQLdb_times.py | Adds/updates assertions for negative and microsecond-precision timedelta formatting and literals. |
| src/MySQLdb/times.py | Revises format_TIMEDELTA to correctly handle negative timedeltas and microseconds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: PyMySQL/PyMySQL#1262