Pass through more settings for environment and gauging sub-algorithms#436
Open
leburgel wants to merge 1 commit into
Open
Pass through more settings for environment and gauging sub-algorithms#436leburgel wants to merge 1 commit into
leburgel wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
... and 72 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
reviewed
Jun 15, 2026
| @@ -65,7 +65,8 @@ end | |||
| function localupdate_step!( | |||
| ::IterativeSolver{<:VOMPS}, state::VOMPSState{<:Any, <:Tuple}, ::SerialScheduler | |||
Member
There was a problem hiding this comment.
Suggested change
| ::IterativeSolver{<:VOMPS}, state::VOMPSState{<:Any, <:Tuple}, ::SerialScheduler | |
| it::IterativeSolver{<:VOMPS}, state::VOMPSState{<:Any, <:Tuple}, ::SerialScheduler |
lkdvos
reviewed
Jun 15, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
Looks like a great addition, thanks!
I had always wanted to have a better way of dealing with the environment algorithms, but I think the annoying part is the distinction between the linear solver for hamiltonians and the eigensolver for MPOs. There might be a case to be made to replace the NamedTuple arguments with actual KrylovKit algorithms from the start too, although I guess that requires slightly more work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to add more control over the VUMPS/VOMPS subroutines.
Previously, only the
tolof the environment algorithm was ever actually passed through to the environment solver in the ends, and there was no way to switch the orthogonalization method from the default value (QR-based orthogonalization. Here I tried to address that passing all of the kwargs in theenvironment_algdown to the solver, and adding the orthogonalization algorithm to the gauging algorithm and passing that down accordingly.