Forward AD tests and cleanup for vector interface

[kshyatt]

No description provided.

[github-actions]

Your PR no longer requires formatting changes. Thank you for your contribution!

[lkdvos]

Cool! Do you have any idea if this would make sense to implement at the VectorInterface level? Alternatively, to not necessarily mark everything as @is_primitive there but to already provide the implementation?

[kshyatt]

We could do it there if it's generic enough? I don't have a strong opinion tbh

[lkdvos]

It looks like all rules are implemented solely in terms of Mooncake or VectorInterface functions, so that might just work?

[kshyatt]

Nice, I can move these over tomorrow then

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines	Coverage Δ
ext/TensorKitMooncakeExt/tangent.jl	65.06% <ø> (+65.06%)	⬆️
ext/TensorKitMooncakeExt/utility.jl	71.42% <ø> (+71.42%)	⬆️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lkdvos]

I think you still need the @is_primitive calls, since the VI rules are only defined for AbstractArray

[kshyatt]

Addressed by another PR over there 😉

[lkdvos]

Do you know if something like this works:

@static if pkgversion(VectorInterface) < v"0.6.0"
    # previous implementation
end

This would allow us to continue supporting old + new version of VectorInterface.

For the current implementation, I guess this might break the rrule implementations that were already there if the correct version of VectorInterface is not loaded. In that case, I would maybe just bite the bullet and actually restrict to VectorInterface v0.6 and just deal with that?

[kshyatt]

Not sure, I can try it tomorrow!