180#181
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180.
#[auto]fields were included in generated INSERTs withDefault::default()values —created_at: DateTime<Utc>wrote an explicit1970-01-01, silently clobbering the table'sDEFAULT now(). Found while validating the crate against a real backend.Fix
columns_str(SELECT, all columns) andinsert_columns_str/placeholders (INSERT, minus#[auto])Insertablestruct, insert bindings and Entity→Insertable mappers skip auto fields; DB defaults apply and persisted values come back viaRETURNING *(the default)DO UPDATE SETalso stops overwriting auto columns (previously resetcreated_aton the update path)returning = "id"/"none"/customthe returned pre-built entity still carries placeholder auto values — unchanged semantics, now documented by the column splitTesting
--all-targets -D warningsclean, all-features suite green, deny ok