184#186
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #184.
Generated code carried
cfg_attr/cfggates referencing facade feature names (api,validate,garde,tracing,postgres). Consumer crates that do not declare those features gotunexpected_cfgswarnings on every entity — and, worse, a consumer without apostgresfeature silently lost the repository impl. Found while validating the crate against a real backend.Fix
postgres/api/validate/garde/tracing), so the macro knows at expansion time what is enabledcfgs to expansion-timecfg!gating: ToSchema/Validate/garde derives, garde field rules,tracing::instrument,sqlx::FromRow, the repository impl block and the constraints mapper are emitted plainly when the feature is on and omitted entirely when offTesting
--all-features,garde,garde+validate(precedence pinned: validator wins, zero garde tokens)-D warningsclean across all targetsNotes