You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed the diff against HEAD^1 (base dev). Scope is a 9-line addition to .github/workflows/rocm-ci.yml inside the shared &run_container anchor (applied to both sGPU and MGPU jobs).
What it does: parses --device=/dev/dri/renderD* entries from DEVICE_FLAG, counts them, and — when non-zero — injects -e ROCR_VISIBLE_DEVICES=0,…,N-1 -e HIP_VISIBLE_DEVICES=0,…,N-1 into docker run. This restricts ROCm/HIP enumeration to the assigned GPUs (necessary because /dev/kfd is shared and otherwise exposes host-wide topology).
Verdict: LGTM. The --device=/dev/dri fallback path is handled correctly (grep matches nothing → empty array → guard skips → "${GPU_ENV[@]}" expands to nothing). Change is minimal, contained, and ROCm-only (no upstream compatibility concern).
Minor nit (non-blocking): RENDER_DEVICES is only used for its length — GPU_COUNT=$(grep -cE '/dev/dri/renderD[0-9]+' <<< "$DEVICE_FLAG") would be equivalent and drop the array. Not worth changing.
Copyright headers: OK (rocm-ci.yml already carries 2024-2026 AMD line; no NVIDIA line expected on ROCm-only workflow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.