Skip to content

Add 2 day wait period for dependencies#164

Open
jdmarshall wants to merge 1 commit into
RafaelGSS:mainfrom
jdmarshall:security
Open

Add 2 day wait period for dependencies#164
jdmarshall wants to merge 1 commit into
RafaelGSS:mainfrom
jdmarshall:security

Conversation

@jdmarshall

Copy link
Copy Markdown
Collaborator

A delay of one or more days is recommended for supply chain attack prevention.

@jdmarshall jdmarshall force-pushed the security branch 2 times, most recently from bd3b669 to 175d318 Compare June 9, 2026 07:53
A delay of one or more days is recommended for supply chain attack prevention.
@jdmarshall

Copy link
Copy Markdown
Collaborator Author

Hmmm. Why is 22 failing?

@H4ad

H4ad commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

It could be caused by a update in the V8 on V22 since the benchmark that is failing is includes.

Comment thread .npmrc

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add more configs, such as trust level.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trustPolicy: no-downgrade
minimumReleaseAge: 2880 # 2d
minimumReleaseAgeStrict: true
blockExoticSubdeps: true

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't those pnpm flags?

Also why the fuck did npm change the units for minimumReleaseAge? The internet tried to get me to use 1440 days and I had to force push a change.

@H4ad H4ad Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.o, I swear we were already using pnpm here, I did so many migrations that I only thought this was a feature only for pnpm 😆

Looks like the npm does not have trust factor or block exotic subdeps :/

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nodejs has a dumpster fire, it's not express, it's npm.

npm warn Unknown project config "minimumReleaseAge". This will stop working in the next major version of npm.

On node 24. wtaf

[Ben_Affleck_Smoking.gif]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants