UI theme settings#226
Conversation
…urrent theme in QSettings
ae8345e to
c196580
Compare
7c3aabc to
1013d50
Compare
There was a problem hiding this comment.
Thanks, works as advertised on Windows and MacOS, the theme does not update properly on Linux because of QT-BUG the problem is fixed in newer PyQT versions - 6.10.2 worked for me.
StephenNneji
left a comment
There was a problem hiding this comment.
Thanks for the update. Sorry I missed this when I last tested: If I change the theme to for example dark from light and I click the cancel button, it stays dark. I think it should revert to light we can easily modify the cancel button slot to reset, I tested this
def cancel_settings(self):
if SETTINGS.style != self.settings.style:
change_ui_style(SETTINGS.style)
self.reject()
Thanks for this check, I thought I covered the cancelling part but I missed it. Sorted it now :) |
Issue #101
This PR impliments RasCAL being displayed in Light or Dark mode depending on the users system settings. As default, this will be synchronised with the OS settings, but it is possible to override this be explicitly selecting Light or Dark mode in the Settings Dialog.
Things to test: