refactor: remove deprecated wait() method from DataVolume class#2704
Open
ema-aka-young wants to merge 2 commits into
Open
refactor: remove deprecated wait() method from DataVolume class#2704ema-aka-young wants to merge 2 commits into
ema-aka-young wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThis PR removes the deprecated ChangesDeprecation removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
redhat-qe-bot
changed the title
Contributor
Author
|
/verified |
ema-aka-young
force-pushed
the
cnv-73197-remove-dv-wait
branch
from
f48f223 to
0a07b2e
Compare
ema-aka-young
force-pushed
the
cnv-73197-remove-dv-wait
branch
from
0a07b2e to
3da5955
Compare
Contributor
Author
|
/verified |
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
Author
Contributor
|
/lgtm |
jpeimer
reviewed
Jun 4, 2026
| def wait(self, timeout=TIMEOUT_10MINUTES, failure_timeout=TIMEOUT_2MINUTES, wait_for_exists_only=False, sleep=1): | ||
| warn( | ||
| message="DataVolume.wait() is deprecated and will be removed in " | ||
| "the next version. Use wait_for_dv_success() instead.", |
Contributor
There was a problem hiding this comment.
The wrapper hasn't branched yet. We planned to remove it in the next version (4.23) ?
Contributor
Author
There was a problem hiding this comment.
Actually, I thought it would be possible to include this as we haven't branched yet...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description:
The intention is to allow
DataVolume.wait()to fall back to the parentResource.wait()method.More details:
What this PR does / why we need it:
Deprecate DataVolume.wait() in favor of wait_for_dv_success() to fix bad practice and prevent bugs.
Which issue(s) this PR fixes:
This PR will allow us to safely de-quarantine https://github.com/RedHatQE/openshift-virtualization-tests/blob/2ee0d6e604bc3ade241bfb1a53879875eb7d2ecc/tests/storage/cdi_import/test_import_http.py#L62
Special notes for reviewer:
This PR needs to be merged first
This PR is part of this task, and continues the work started in #2613
Bug:
Summary by CodeRabbit
wait()method from DataVolume. This is a breaking change—applications relying on this method will require updates. The removal eliminates deprecation warnings and simplifies the DataVolume interface.