Add intrinsics support, Add nanobench + documentation + example#49
Add intrinsics support, Add nanobench + documentation + example#49mcdubhghlas wants to merge 5 commits into
Conversation
|
This is the output for the benchmark test I added: My computer: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughIntroduces optional benchmark support: a ChangesBenchmark infrastructure and Vector4 benchmark
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmake/Modules.cmake`:
- Around line 90-107: The benchmark executables created in the BUILD_BENCHMARKS
block are currently part of the default ALL build, which bypasses the intended
benchmarks/run-benchmarks workflow. Update the add_executable call for each
BENCH_TARGET in Modules.cmake to exclude these targets from ALL, while keeping
the existing target registration and linkage intact. Use the BENCH_TARGET
creation path in the BUILD_BENCHMARKS foreach loop to locate the change and
preserve the aggregated DRACO_BENCH_TARGETS behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e4e63d88-10ac-4805-bc36-a1bbcaf007b2
📒 Files selected for processing (7)
CMakeLists.txtDocs/benchmarking.mdEngine/cpp/Runtime/Core/Math/Vector4.bench.cppEngine/cpp/Runtime/Core/Math/Vector4.cppmEngine/cpp/Runtime/Platform/intrinsics.hEngine/cpp/ThirdParty/nanobench/nanobench.hcmake/Modules.cmake
Co-authored-by: Jon <14169426+JoltedJon@users.noreply.github.com>
Title.
Summary by CodeRabbit
New Features
Documentation