Sync with Redot 26.2-stable#38
Conversation
Also removed the CI builds for double precision. We dont distribute binaries for this anyways, and with Godot 4.5 they started including the single precision metadata into the `extension_api.json` which causes failures.
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pull request removes Linux double-precision CI jobs, refreshes the extension API JSON, and expands the GDExtension interface with new callbacks, version structures, registration APIs, and script-instance support. ChangesExtension API and CI updates
Estimated code review effort: 5 (Critical) | ~120 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@gdextension/gdextension_interface.h`:
- Line 2848: Update the interface-loading initialization in src/godot.cpp to
look up and assign get_godot_version2, object_set_script_instance,
classdb_register_extension_class5, and register_main_loop_callbacks alongside
the existing get_godot_version and classdb_register_extension_class4 entries,
before any corresponding APIs are used.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f858600f-3b3a-41c8-b972-38e56448c9b8
📒 Files selected for processing (4)
.github/workflows/ci-cmake.yml.github/workflows/ci-scons.ymlgdextension/extension_api.jsongdextension/gdextension_interface.h
💤 Files with no reviewable changes (2)
- .github/workflows/ci-scons.yml
- .github/workflows/ci-cmake.yml
| * @param p_object A pointer to the Object. | ||
| * @param p_script_instance A pointer to the script instance data to attach to this object. | ||
| */ | ||
| typedef void (*GDExtensionInterfaceObjectSetScriptInstance)(GDExtensionObjectPtr p_object, GDExtensionScriptInstanceDataPtr p_script_instance); |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
rg -nP -C2 'get_godot_version2|object_set_script_instance|register_extension_class5|register_main_loop_callbacks' --type=cpp --type=cRepository: Redot-Engine/redot-cpp
Length of output: 160
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Top-level files:\n'
git ls-files | sed -n '1,200p'
printf '\nSearch for the new interface symbols and binding-layer lookup patterns:\n'
rg -n --hidden --no-ignore -S \
'get_godot_version2|object_set_script_instance|classdb_register_extension_class5|register_main_loop_callbacks|LOAD_PROC_ADDRESS|load_proc|proc_address|register_extension_class4|register_extension_class5' \
.Repository: Redot-Engine/redot-cpp
Length of output: 28857
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'src/godot.cpp around the loader table:\n'
sed -n '300,330p' src/godot.cpp
printf '\n'
sed -n '460,505p' src/godot.cpp
printf '\ninclude/godot_cpp/core/class_db.hpp around the registration call:\n'
sed -n '270,290p' include/godot_cpp/core/class_db.hppRepository: Redot-Engine/redot-cpp
Length of output: 7325
Load the new interface entries in src/godot.cpp. get_godot_version2, object_set_script_instance, classdb_register_extension_class5, and register_main_loop_callbacks are declared in gdextension_interface.h, but the binding still only loads the older get_godot_version/classdb_register_extension_class4 paths. Add the missing lookups before using these APIs; otherwise they remain unusable from the C++ layer.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@gdextension/gdextension_interface.h` at line 2848, Update the
interface-loading initialization in src/godot.cpp to look up and assign
get_godot_version2, object_set_script_instance,
classdb_register_extension_class5, and register_main_loop_callbacks alongside
the existing get_godot_version and classdb_register_extension_class4 entries,
before any corresponding APIs are used.
1 participant
Also removed the CI builds for double precision. We dont distribute binaries for this anyways, and with Godot 4.5 they started including the single precision metadata into the
extension_api.jsonwhich causes failures.Summary by CodeRabbit
New Features
Updates
CI