Skip to content

ENH: support fixed-time parachute deployment triggers (#437) - #1133

Open
thatrandomasiandev wants to merge 1 commit into
RocketPy-Team:developfrom
thatrandomasiandev:enh/437-time-delay-parachute
Open

ENH: support fixed-time parachute deployment triggers (#437)#1133
thatrandomasiandev wants to merge 1 commit into
RocketPy-Team:developfrom
thatrandomasiandev:enh/437-time-delay-parachute

Conversation

@thatrandomasiandev

Copy link
Copy Markdown

Summary

  • Adds trigger=("time", t_deploy) so parachutes can deploy at a fixed flight time from launch (motor delay-charge style), addressing ENH: Addition of Time Delay Parachute Deployment #437.
  • Flight sets parachute._eval_time before evaluating triggers; no change to the public (p, h, y, sensors, u_dot) triggerfunc signature.
  • Burnout-referenced delays are supported by composing with the motor: ("time", motor.burn_out_time + delay). A native ("burnout", delay) trigger is left as a follow-up to avoid coupling Parachute construction to motor state.

Test plan

  • Unit tests for ("time", t) True/False at boundary times, ascent-safe behavior, invalid forms, serialization
  • Flight._evaluate_parachute_trigger sets _eval_time and fires correctly
  • StochasticParachute accepts/rejects time triggers consistently with Parachute
  • Integration flight test: deploy within one sampling interval of t_deploy

Fixes #437

@thatrandomasiandev
thatrandomasiandev requested a review from a team as a code owner August 11, 2026 01:47
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 14, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.82%. Comparing base (e0ff281) to head (26c35de).
⚠️ Report is 53 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/stochastic/stochastic_parachute.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1133      +/-   ##
===========================================
+ Coverage    82.18%   82.82%   +0.64%     
===========================================
  Files          122      129       +7     
  Lines        16355    16839     +484     
===========================================
+ Hits         13441    13947     +506     
+ Misses        2914     2892      -22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH: Addition of Time Delay Parachute Deployment

1 participant