TST: cover Function unit conversions - #1157
Open
ting-hong-shieh wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1157 +/- ##
===========================================
+ Coverage 82.18% 83.51% +1.33%
===========================================
Files 122 130 +8
Lines 16355 17082 +727
===========================================
+ Hits 13441 14266 +825
+ Misses 2914 2816 -98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ting-hong-shieh
marked this pull request as ready for review
August 14, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add two behavior tests for the
Functionbranch ofconvert_units():Functioncontract.This changes tests only. It does not modify unit-conversion behavior.
Refs #709.
Revisions
62aa0f9be32eeccafbc1aefd6ac3d90306b257ce2bd510ac7a5b93b10b8b03ca117feb75c6597380Before and after
The same targeted test and coverage command was run at the base and head revisions.
rocketpy/units.pystatementstests/unit/test_units.pyValidation
The array assertions use NumPy's
assert_allclosedefaults:rtol=1e-7andatol=0.Environment
Scope
The coverage comparison is limited to the targeted units test file. I did not use this focused run to claim a full non-slow-suite coverage increase.