BUG: Remove duplicate controller call in Flight.__simulate#960
Closed
Krissal1234 wants to merge 1 commit into
Closed
BUG: Remove duplicate controller call in Flight.__simulate#960Krissal1234 wants to merge 1 commit into
Krissal1234 wants to merge 1 commit into
Conversation
Gui-FernandesBR
force-pushed
the
fix/duplicate-controller-call-in-simulate
branch
from
52f9086 to
9b31d26
Compare
| - BUG: Duplicate _controllers in Flight.TimeNodes.merge() [#931](https://github.com/RocketPy-Team/RocketPy/pull/931) | ||
| - BUG: Fix incorrect Jacobian in `only_radial_burn` branch of `SolidMotor.evaluate_geometry` [#935](https://github.com/RocketPy-Team/RocketPy/pull/935) | ||
| - BUG: Add explicit timeouts to ThrustCurve API requests [#935](https://github.com/RocketPy-Team/RocketPy/pull/935) | ||
| - BUG: Remove duplicate controller call in Flight.__simulate [#959](https://github.com/RocketPy-Team/RocketPy/issues/959) |
Member
|
seems like this problem has already been solved. We just have to locate the original PR and link it here |
Member
|
Closing because this was already solved in #949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
CHANGELOG.mdhas been updated (if relevant)Current behavior
Controllers are called twice per time node in
Flight.__simulate. See #959.New behavior
Controllers are called exactly once per time node, inside
__process_sensors_and_controllers_at_current_nodeas intended.Breaking change
Additional information
The duplicate loop was introduced in #843 when
__process_sensors_and_controllers_at_current_nodewas addedfor sensor and controller processing, but the original
controller loop in
__simulatewas not removed.