fix(http): refine Proxy-Authenticate basic auth workflow#103
Closed
tianhuyang wants to merge 5 commits into
Closed
fix(http): refine Proxy-Authenticate basic auth workflow#103tianhuyang wants to merge 5 commits into
tianhuyang wants to merge 5 commits into
Conversation
Author
|
@nekohasekai @wwqgtxx could you please take a look at this small header-format fix when convenient? Thank you. |
2ae5b05 to
6c597e4
Compare
Author
|
Not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the original HTTP proxy auth header formatting fix with follow-up reliability and observability improvements in
protocol/http/handshake.go.What Changed
Proxy-Authenticateheader formatting fix:Basic realm="sing-box", charset="UTF-8"Proxy-Authorizationwhen retry is safe.HTTPServerOptions.ProxyAuthRetryTimeout(default 5s).HTTPServerOptions.Logger(logger.ContextLogger) withlogger.NOP()fallback.Authorization,Proxy-Authorization,Cookie,Set-Cookie.Tests
Added/updated tests in
protocol/http/handshake_test.go, including:Validation
CGO_ENABLED=0 go test ./protocol/httpCGO_ENABLED=0 go test ./...Notes
This PR now covers the full set of HTTP proxy auth handshake updates currently on branch
fix/http-proxy-auth-header-comma.