feat: adopt Tailwind CSS utility classes for styling - #17
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlto use Tailwind CSS utility classes (with arbitrary-value bracket syntax for exact px/rem/gradients/shadows/colors) instead of custom app-owned CSS classes. Visual appearance and behavior are unchanged — this is a pure refactor.src/css/style.css) down to just the@screenly/edge-apps/stylesdesign-system import layered correctly against Tailwind's theme/utilities layers. Deletessrc/css/grid.cssandsrc/css/kanban.css, since all their rules are now expressed as Tailwind utility classes directly on the corresponding elements (both static markup inindex.htmland dynamically-created elements insrc/app.ts/src/kanban.ts).kanban-card,kanban-card-title,kanban-column,kanban-column-header,kanban-column-dot,kanban-column-title,kanban-cards,cell-pills,pill) are preserved verbatim alongside the new utility classes.#data-table th,#data-table td, etc.) with no className set insrc/app.ts, now get Tailwind utility classNames assigned at creation time. The "divider" line between rows (all but the last row) is now expressed via the[&:not(:last-child)]:bg-[...]arbitrary-variant pattern instead of a static CSS:last-childrule — same visual result, recomputed automatically by the browser as rows are added/removed bytrimRowsToFit().@screenly/edge-appsto^1.3.0(unpublished; ships Tailwind support).screenshots/*(grid + kanban views, all resolutions) to reflect the change (pixel-identical to before).Reference/pilot migrations for this same rollout:
Test plan
bun run type-check— passesbun run lint— passesbun test --pass-with-no-tests src/— 51 tests pass (including class-name assertions inkanban.test.ts/render.test.ts)bun run format:check— passesbun run build— succeedsbun run screenshots— all 20 Playwright screenshot tests pass; visually confirmed grid view (landscape + portrait) and kanban view render correctly with no missing text or broken layoutpackage.json/bun.lockare clean of the temporary local-tarball reference used to test against the unpublished@screenly/edge-apps@1.3.0build; only the version bump string is committed, lockfile untouched