feat: adopt Tailwind CSS utility classes for styling - #6
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts
calendar-app'sindex.htmland CSS entry point to Tailwind CSS utility classes, part of the company-wide edge-app rollout. This app's own repo previously had no in-repo custom CSS at all — the top-level app shell (#app,.header,.content,.calendar-view/.active) was styled via a bundled stylesheet shipped by@screenly/edge-apps(@screenly/edge-apps/styles/calendar-app). Those rules have been inlined as Tailwind utilities directly inindex.html, and the CSS entry point now only pulls in the generic Tailwind layer + design-system base styles, matching the reference pattern.index.html: replaced the app-shell styling (bodybackground,#appflex/background,.headermargin/width/background/color,.contentflex/padding,.calendar-view/.activeshow/hide) with Tailwind utility classes, using arbitrary-value syntax for exact values (w-[calc(100%-2.625rem)],bg-[var(--theme-color-primary,#0f3a97)], etc). Theactiveclass toggled bysrc/main.ts(classList.add('active')) is preserved and now driven via the[&.active]:flexarbitrary variant instead of a.calendar-view.activeCSS rule.src/css/style.css: slimmed to the standard Tailwind layer setup (@layer theme, base, utilities;+ the three@imports), dropping the@screenly/edge-apps/styles/calendar-appimport now that its app-shell rules live in the HTML. Note: the individual calendar view web components (schedule-calendar-view,weekly-calendar-view,daily-calendar-view) render their own internals via shadow-DOM styles baked into the@screenly/edge-appslibrary package itself — those are out of scope for this repo and unaffected by this change.package.json: bumped@screenly/edge-appsto^1.3.0(unpublished version that will ship Tailwind support).schedule/weekly/daily× 10 resolutions) to reflect (no visual diff intended — pure refactor).Reference pattern from the pilot conversions:
Test plan
bun run type-check— passesbun run build— passes (only pre-existing, unrelatedimport.meta/chunk-size warnings)bun run screenshots— all 30 screenshots regenerated successfully@screenly/edge-apps@1.3.0(tested against the local unpublished tailwind-support build);package.json/lockfile were reset back to the committed^1.2.1-resolving lockfile with only the version range bumped to^1.3.0, matching how the reference PRs handled the not-yet-published dependency.