feat: adopt Tailwind CSS utility classes for styling - #35
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates this app's styling to Tailwind CSS utility classes, following the same pattern established by:
Changes:
index.html: replaced custom app-shell/error-screen classes with Tailwind utility classes (arbitrary-value bracket syntax used for exact px/rem values, colors, and the design-system--z-index-contenttoken), using theportrait:variant for the existing@media (orientation: portrait)override on the error card.src/render/report.ts,src/render/table.ts,src/render/utils.ts: dynamically-created elements (chart-card,chart-title,chart-container,report-stat*,metric-value,empty-state,table-scroll,data-table) now get Tailwind utility strings appended alongside their existing (preserved) class names. The per-row "no bottom divider on the last row" behavior (tbody tr:last-child td { background-image: none }) is now expressed withgroupon<tr>andgroup-last:bg-noneon<td>, with no change to the render logic.src/css/style.css: slimmed down to the standard Tailwind layer setup +@screenly/edge-apps/stylesimport.package.json: bumped@screenly/edge-appsto^1.3.0(unpublished; ships Tailwind support).screenshots/.No visual or behavioral changes are intended — this is a pure styling refactor.
Test plan
bun run type-check— passesbun run build— succeeds (pre-existing warnings unrelated to this change)bun test --isolate --pass-with-no-tests src/— 57 pass / 0 failbun run screenshots— all 19 Playwright screenshot specs pass@screenly/edge-appsinstall fully discarded afterward (package.json/lockfile reset to committed state, then only the version-string bump re-applied); lockfile is untouched in this PR