feat: adopt Tailwind CSS utility classes for styling - #6
Draft
nicomiguelino wants to merge 1 commit into
Draft
Conversation
Rework index.html to use Tailwind utility classes instead of custom CSS classes, keeping visual appearance and behavior unchanged. Slim the CSS entry point down to just the design-system import. Bump @screenly/edge-apps to ^1.3.0 for upcoming Tailwind CSS support. Regenerate screenshots to reflect the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlto use Tailwind utility classes instead of custom CSS classes (.header,.content,.welcome-heading,.welcome-message), using arbitrary-value bracket syntax to reproduce every px/rem/color/gradient value exactly, plus aportrait:variant for the existing@media (orientation: portrait)overrides.src/css/style.cssdown to just the layered Tailwind + design-system import (theme/base/utilities), matching the pattern from the other migrated apps.@screenly/edge-appsto^1.3.0inpackage.jsonfor the upcoming Tailwind CSS support release (not yet published).screenshots/*.webpto reflect the (visually identical) markup change.No JS/TS behavior changed —
src/app.tsandsrc/app.test.tsonly reference the#welcome-heading/#welcome-messageIDs, which are untouched.Reference implementations (pilot migrations for this company-wide rollout):
Test plan
bun run type-checkpassesbun run buildsucceeds (built against the local unpublished@screenly/edge-apps@1.3.0tailwind-support tarball, then revertedpackage.json/bun.lockto the committed dependency version before committing — only the^1.3.0version bump is retained)bun test --pass-with-no-tests src/— 4/4 tests passbun run screenshotsregenerated all 10 screenshots; visually spot-checked landscape (1920x1080) and portrait (1080x1920) — layout, text, and background render correctly with no regressions