Skip to content

fix(order): keep order test on public headers#21

Merged
SebastianBoehler merged 1 commit into
mainfrom
codex/fix-order-test-public-headers
Jun 16, 2026
Merged

fix(order): keep order test on public headers#21
SebastianBoehler merged 1 commit into
mainfrom
codex/fix-order-test-public-headers

Conversation

@SebastianBoehler

Copy link
Copy Markdown
Owner

Summary

  • update order_test.cpp to use the public ClobClient order path instead of the private order_execution.hpp helper header
  • let CreateMarketOrderParams accept cached neg_risk, matching CreateOrderParams and avoiding an extra lookup in the sample
  • bump patch version/docs to v1.2.5 for the consumer-facing fix

Verification

  • cmake --build /tmp/polymarket-issue20-build --target order_test test_order_execution -j 8
  • ctest --test-dir /tmp/polymarket-issue20-build --output-on-failure
  • installed package smoke: order_signer.hpp exists, order_execution.hpp remains private, public-header consumer compile passes

@SebastianBoehler SebastianBoehler merged commit 4feed62 into main Jun 16, 2026
8 checks passed
@SebastianBoehler SebastianBoehler deleted the codex/fix-order-test-public-headers branch June 16, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant