[rb] route BiDiBridge navigation through the generated Protocol::BrowsingContext#17785
[rb] route BiDiBridge navigation through the generated Protocol::BrowsingContext#17785titusfortner wants to merge 1 commit into
Conversation
PR Summary by QodoRoute BiDiBridge navigation through generated BiDi::Protocol::BrowsingContext
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
19 rules 1. BiDiBridge navigation lacks tests
|
|
Code review by qodo was updated up to the latest commit 5bd9a18 |
5bd9a18 to
66a391d
Compare
|
Code review by qodo was updated up to the latest commit 66a391d |
66a391d to
c63ced9
Compare
|
Code review by qodo was updated up to the latest commit c63ced9 |
🔗 Related Issues
Part of the Ruby BiDi protocol generator rollout (foundation: #17731).
💥 What does this PR do?
Routes the Ruby
BiDiBridge's own navigation —get,back,forward,refresh— through the generatedBiDi::Protocol::BrowsingContextinstead of the hand-writtenBiDi::BrowsingContext. This makesdrivernavigation the first production consumer of the generated BiDi protocol layer, rather than it being reachable only through integration specs. No user-facing behavior change.🔧 Implementation Notes
The generated layer never reads capabilities, so the bridge supplies the two things it omits: the
context(current window handle) and thewaitreadiness mapped frompage_load_strategy.One wire nuance: when
page_load_strategyis absent the bridge now defaults tonormal(→complete) rather than the previouswait: null— the generated readiness enum is non-nullable. The commonnormal/eager/nonecases are unchanged.refreshomitsignoreCache— a plain reload doesn't need it, and Firefox rejects the (correctly-named) param as unimplemented. The old path sent it mis-cased, so Firefox ignored it anyway; behavior is unchanged.🤖 AI assistance
BiDiBridgenavigation implementation💡 Additional Considerations
BrowsingContextmethods is for a future PR.🔄 Types of changes