Skip to content

[Klaud Cold] Update minimaxm2.5-fp8-mi355x-vllm vLLM ROCm image to v0.22.0#1617

Merged
functionstackx merged 2 commits into
mainfrom
klaud-cold/minimaxm2.5-fp8-mi355x-vllm-v0.22.0
May 31, 2026
Merged

[Klaud Cold] Update minimaxm2.5-fp8-mi355x-vllm vLLM ROCm image to v0.22.0#1617
functionstackx merged 2 commits into
mainfrom
klaud-cold/minimaxm2.5-fp8-mi355x-vllm-v0.22.0

Conversation

@functionstackx
Copy link
Copy Markdown
Collaborator

@functionstackx functionstackx commented May 30, 2026

Summary

Update vLLM ROCm image from v0.21.0 to v0.22.0

Recipes touched: minimaxm2.5-fp8-mi355x-vllm

Test plan

  • full-sweep-enabled sweep passes.

🤖 Generated with Claude Code


Note

Low Risk
Config-only container tag bump with no sweep or launch-script changes; risk is limited to v0.22.0 runtime behavior on MI355X until the full sweep passes.

Overview
Bumps the MiniMax-M2.5 FP8 on MI355X vLLM ROCm benchmark recipe from vllm/vllm-openai-rocm:v0.21.0 to v0.22.0 in .github/configs/amd-master.yaml for config key minimaxm2.5-fp8-mi355x-vllm. Model, runner, parallelism, and fixed-seq-len search space are unchanged.

Adds a matching perf-changelog.yaml entry documenting the image bump and linking PR #1617.

Reviewed by Cursor Bugbot for commit be53b33. Bugbot is set up for automated code reviews on this repo. Configure here.

….22.0

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@functionstackx functionstackx force-pushed the klaud-cold/minimaxm2.5-fp8-mi355x-vllm-v0.22.0 branch from 53472a1 to e32607b Compare May 30, 2026 22:11
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook

If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow

As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers.

If additional help is needed, PR authors can reach out to core maintainers over Slack.

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple vLLM ROCm image tag bump for a single recipe with matching changelog entry.

Extended reasoning...

Overview

This PR bumps the vLLM ROCm image tag from v0.21.0 to v0.22.0 for the minimaxm2.5-fp8-mi355x-vllm recipe in .github/configs/amd-master.yaml, and adds a corresponding entry to perf-changelog.yaml linking back to this PR.

Security risks

None. This is a YAML config tweak that swaps a container image tag for a published vLLM ROCm release. No code paths, auth, secrets, or permissions are touched.

Level of scrutiny

Low. Image tag bumps for sweep recipes are the most common type of change in this repo, and the full-sweep-enabled label triggers the sweep validation. Correctness is validated empirically by the sweep itself, not by static review.

Other factors

The bug hunting system found no issues. The change is self-contained, follows the established pattern used by sibling recipes (many of which already pin to v0.21.0 or other specific versions), and the changelog entry is properly formatted with the PR link.

@github-actions
Copy link
Copy Markdown
Contributor

@functionstackx
Copy link
Copy Markdown
Collaborator Author

/reuse-sweep-run

@functionstackx functionstackx merged commit 3b980b8 into main May 31, 2026
5 of 6 checks passed
@functionstackx functionstackx deleted the klaud-cold/minimaxm2.5-fp8-mi355x-vllm-v0.22.0 branch May 31, 2026 00:45
@github-actions
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

1 participant