[Tests] Remove filesystem mocks in result.test.ts#7624
Conversation
Refactor `packages/store/src/cli/services/store/execute/result.test.ts` to remove global `vi.mock('@shopify/cli-kit/node/fs')` and use real filesystem operations in temporary directories.
Also simplified output verification by mocking `outputResult` instead of manually capturing standard streams, which avoids issues with memoized environment checks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Refactor
packages/store/src/cli/services/store/execute/result.test.tsto remove globalvi.mock('@shopify/cli-kit/node/fs')and use real filesystem operations in temporary directories.Also simplified output verification by mocking
outputResultinstead of manually capturing standard streams, which avoids issues with memoized environment checks.How to test your changes?
CI
Measuring impact
Improved test reliability and alignment with project testing standards.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 13044395455621622009 started by @gonzaloriestra