Skip to content

[Security] Harden devConsoleAssetsMiddleware against path traversal#7625

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-dev-console-assets-traversal-15346866280291798229
Draft

[Security] Harden devConsoleAssetsMiddleware against path traversal#7625
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-dev-console-assets-traversal-15346866280291798229

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The devConsoleAssetsMiddleware was vulnerable to path traversal attacks because it joined user-provided assetPath with the rootDirectory without validating that the resulting path remained within the intended directory.

WHAT is this pull request doing?

  • Updated devConsoleAssetsMiddleware in packages/app/src/cli/services/dev/extension/server/middlewares.ts to use resolvePath and isSubpath for path validation.
  • Added regression tests in packages/app/src/cli/services/dev/extension/server/middlewares.test.ts.
  • Ensured proper use of utilities.sendError for error handling in the middleware.

How to test your changes?

CI handles testing. You can also run the specific tests:
pnpm --filter app vitest run src/cli/services/dev/extension/server/middlewares.test.ts

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 15346866280291798229 started by @gonzaloriestra

This PR hardens the `devConsoleAssetsMiddleware` against path traversal attacks by ensuring that any requested asset is contained within the intended root directory. We now resolve the candidate path and use the `isSubpath` utility to verify it remains within the `rootDirectory`.

Regression tests have been added to verify that valid assets are served correctly and that traversal attempts (e.g., using `..`) result in a 404 error.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 25, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant