[Tests] Cover global-context utility#8134
Conversation
Implement full coverage for packages/cli-kit/src/public/node/global-context.ts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/global-context.d.ts@@ -12,4 +12,8 @@ export declare function getCurrentCommandId(): string;
*
* @param commandId - Command ID.
*/
-export declare function setCurrentCommandId(commandId: string): void;
\ No newline at end of file
+export declare function setCurrentCommandId(commandId: string): void;
+/**
+ * Reset the global context (for testing purposes).
+ */
+export declare function _resetGlobalContext(): void;
\ No newline at end of file
|
WHY are these changes introduced?
packages/cli-kit/src/public/node/global-context.tshad no dedicated unit tests and 0% test coverage.WHAT is this pull request doing?
_resetGlobalContext()inpackages/cli-kit/src/public/node/global-context.tsto allow safe, clean state reset in unit testing.packages/cli-kit/src/public/node/global-context.test.tsto fully cover getter (getCurrentCommandId), setter (setCurrentCommandId), and reset functionalities.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 2714055448027004875 started by @gonzaloriestra