Skip to content

Raise pipelined meta protocol errors after draining#76

Draft
mrattle wants to merge 2 commits into
Shopify:mainfrom
mrattle:mark/raise-pipelined-meta-errors
Draft

Raise pipelined meta protocol errors after draining#76
mrattle wants to merge 2 commits into
Shopify:mainfrom
mrattle:mark/raise-pipelined-meta-errors

Conversation

@mrattle

@mrattle mrattle commented Jun 22, 2026

Copy link
Copy Markdown

Summary

  • detect CLIENT_ERROR, SERVER_ERROR, and ERROR in pipelined meta responses
  • keep draining pipelined responses through MN before raising the first protocol error
  • cover first, middle, and last pipelined error positions in tests

Testing

  • ruby -c lib/dalli/protocol/meta/response_processor.rb
  • ruby -c lib/dalli/protocol/response_buffer.rb
  • ruby -c lib/dalli/protocol/base.rb
  • ruby -c lib/dalli/protocol/meta.rb
  • ruby -c test/protocol/meta/test_response_processor.rb

Note: running the targeted test file with bundle exec currently fails locally due a Ruby/stringio binary incompatibility in this environment.

mrattle added 2 commits June 22, 2026 08:22
Assisted-By: devx/e7039bf1-bf72-4e1b-9d21-37fb7420d7f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant